[MPlayer-dev-eng] Re: [PATCH] make demuxer_get_percent_pos() recheck file length

[Oded Shimon]

On Mon, Oct 03, 2005 at 12:55:33PM -0500, Joey Parrish wrote:
> On Mon, Oct 03, 2005 at 09:07:31AM +0300, Oded Shimon wrote:
> > On Sun, Oct 02, 2005 at 10:56:05PM -0700, Scott W. Larson wrote:
> > > Alban Bedel wrote:
> > > >The fd field could be anything (ie there not even a guarentee that
> > > >it acctually hold a fd), 
> > > 
> > > I was trusting this comment in libmpdemux/stream.h.:
> > > 
> > >    typedef struct stream_st {
> > >    :
> > >       int fd;   // file descriptor, see man open(2)
> > >    :
> > 
> > A stream can be anything.. what about windows, if i'm not mistaken windows 
> > doesn't even have such a thing... playing with this fd is like playing with 
> > the internals of something you shouldn't be touching..
> 
> If you're suggesting that windows doesn't have file descriptors, then
> you're wrong.

I dunno anything about windows API, but does it have integer file 
descriptors?.. as far as i know it doesn't... either way, these veriable 
should not be used from this function..

- ods15