[MPlayer-dev-eng] [PATCH] si2us() in libaf is off-by-one

[Diego Biurrun]

On Tue, Oct 04, 2005 at 09:43:22PM +0200, Reimar Döffinger wrote:
> On Tue, Oct 04, 2005 at 09:34:27PM +0200, Diego Biurrun wrote:
> > These all produce noise when I adjust the volume.
> 
> Don't know. In theory adjusting volume shouldn't change much. Actually
> the only question is if this happened before, too :-)

Happened before as well.

> > > > And also things like -af format=s8,format=u16le
> > > > In theory it should be possible to test all conversions like this...
> > 
> > -af format=s8,format=s16be works, although some hissing is added.  I
> > guess this might all be intended...
> 
> Yes, 8 bit is not exactly precise. You could just as well try -af
> format=s24be,format=s16be etc. Shouldn't add hissing then.

Yes, works.

Diego