[MPlayer-dev-eng] Small changes to subreader.c file

Guillaume POIRIER poirierg at gmail.com
Fri Oct 7 19:56:36 CEST 2005


Hi,

On 10/6/05, Salvatore Falco <sfalco at studenti.ing.uniroma1.it> wrote:
> I think that using MSGL_INFO as debugging level is too much. Most people does
> not care about incorrect subs, so we should not add more verbosity to MSGL_INFO
> output.

I'm pretty undecided about this issue. A simple script ala unix2dos
that converts all \n to \r\n could the the job just as well if you
want to make sure your file doesn't have any \n alone.


Maybe the patch subreader.patch2 could be safely applied (as it
probably won't break anything) but I've got to say I'm not convinced
that this patch is neither necessary (do decent players choke on this
kind of file?) nor desirable (MPlayer being used a lot more on Unix
platforms, it seem more natural to use the UNIX carriage return)

Guillaume

--
Reading doesn't hurt, really!
  -- Dominik 'Rathann' Mierzejewski




More information about the MPlayer-dev-eng mailing list