[MPlayer-dev-eng] Small changes to subreader.c file

Joey Parrish joey at nicewarrior.org
Fri Oct 7 23:21:29 CEST 2005


On Fri, Oct 07, 2005 at 03:43:42PM -0400, Rich Felker wrote:
> On Thu, Oct 06, 2005 at 12:22:00PM +0200, Adam Tla??ka wrote:
> > Hello,
> > I am sending a small patch which adds "\r\n" (DOS line endings) to  
> > dump_srt function
> > which is a bug correction because SRT is really a DOS format and will not  
> > be
> > properly read with Unix like "\n" line endings.
> 
> This is not a bug. .srt files are text files and as such should be
> stored in (standard) unix text format. If windows/dos/mac/etc users
> want to use them they can apply the appropriate (broken) textfile
> conversions.

I disagree.  If we are dealing with a text-based format, we should be
able to read CR or LF or CRLF.  If we are writing it, we should write
whatever is either 1) standard or 2) most compatible.  If there is no
SRT standard spec, this means we should output CRLF.

Is there an SRT standard?

--Joey

-- 
"There are trivial truths and there are great truths.  The opposite of a
trivial truth is plainly false.  The opposite of a great truth is also true."
  --Neils Bohr




More information about the MPlayer-dev-eng mailing list