[MPlayer-dev-eng] [PATCH] configure does not detect faac

[Jindrich Makovicka]

Diego Biurrun wrote:
> On Sun, Oct 09, 2005 at 11:23:50AM +0200, Reimar Döffinger wrote:
> 
>>On Wed, Oct 05, 2005 at 03:04:26PM -0400, Giacomo Comes wrote:
>>
>>>--- configure.ori	2005-10-05 14:54:11.000000000 -0400
>>>+++ configure	2005-10-05 14:54:31.000000000 -0400
>>>@@ -5431,7 +5431,7 @@
>>> EOF
>>>   _faac=no
>>>   for _ld_tmp in "-lfaac" "-lfaac -lmp4v2 -lstdc++" ; do
>>>-    cc_check -c -O4 $_ld_tmp $_ld_lm && _ld_faac="$_ld_tmp" && faac=yes && break
>>>+    cc_check -c -O4 $_ld_tmp $_ld_lm && _ld_faac="$_ld_tmp" && _faac=yes && break
>>
>>Btw, I think this is still nonsense... what are all the -l options good
>>for when no linking is done (-c)?? I'd say it always picks just -lfaac.
> 
> 
> That's not really the point of the patch, though, the typo fix is still
> valid.
> 
> But yes, probably that check could be simplified...

imho -c is superfluous and should be removed.

-- 
Jindrich Makovicka