[MPlayer-dev-eng] [PATCH] esd: support non-default tcp port

[Diego Biurrun]

On Sat, Oct 08, 2005 at 09:19:43PM +0200, Németh Márton wrote:
> 
> I made a copy of ao_subdevice in libao2/ao_esd.c:init(), because 
> unfortunately the ESD library overwrites the input paratmeter if it 
> contains the port address. Now with this copy the followings are possible:
> 
> 	-ao esd
> 	-ao esd:server
> 	-ao esd:server:16001

Some quick remarks, I haven't tested all of the patch, though...

> --- ../../mplayer-cvs.orig/main/DOCS/man/en/mplayer.1	2005-10-06 14:42:48.000000000 +0200
> +++ ./DOCS/man/en/mplayer.1	2005-10-08 20:57:45.000000000 +0200
> @@ -1959,6 +1959,15 @@
>  .RSs
>  .IPs <server>
>  Explicitly choose the ESD server to use (default: localhost).
> +.IPs <port>
> +Explicitly choose the TCP port where ESD server listens.
> +If specified this must be the second suboption. (default: 16001)

It should be clear from the syntax description that it has to be the
second suboption, so leave that remark out.

> +.sp 1
> +.I \ \ \ \ \ \ \ EXAMPLES:
> +.RSs
> +.IPs -ao\ esd
> +.IPs -ao\ esd:server
> +.IPs -ao\ esd:server:16001

Leave out the example, it should be pretty clear on its own.

> + * We can use the suboptions string as is, because subotions

typo: suboPtion

Diego