[MPlayer-dev-eng] [PATCH] verbosity reduction

[Oded Shimon]

On Sun, Sep 18, 2005 at 09:22:30PM +0200, Diego Biurrun wrote:
> Here is another in my seemingly endless series of small patches that
> reduce overall verbosity bit by bit.
> 
> Comment or see this applied in a few days ;)

I've looked over the patch and I admit that I didn't read it right the 
first time, and there are some parts I agree, but still some I don't...

> --- cpudetect.c	25 May 2005 08:48:31 -0000	1.40
> +++ cpudetect.c	18 Sep 2005 19:17:35 -0000
> [...]
>  #ifdef ARCH_VAX
> -	mp_msg(MSGT_CPUDETECT,MSGL_INFO, "CPU: Digital VAX\n" );
> +	mp_msg(MSGT_CPUDETECT,MSGL_V, "CPU: Digital VAX\n" );
>  #endif

You're inconsistent with this, you removed all the 'CPU: ' messages except 
the one on x86, at line 139 in cpudetect.c .
Regardless, I'm against all verbosity reduction on the cpudetect, I like 
those messages, helps me find out what features a cpu has, and doing this 
would effectively COMPLETELY disable them, as -v doesn't apply here...

> Index: mplayer.c
> -  mp_msg(MSGT_CPLAYER,MSGL_INFO,"CPUflags:  MMX: %d MMX2: %d 3DNow: %d 3DNow2: %d SSE: %d SSE2: %d\n",
> +  mp_msg(MSGT_CPLAYER,MSGL_V,"CPUflags:  MMX: %d MMX2: %d 3DNow: %d 3DNow2: %d SSE: %d SSE2: %d\n",
>        gCpuCaps.hasMMX,gCpuCaps.hasMMX2,
>        gCpuCaps.has3DNow, gCpuCaps.has3DNowExt,
>        gCpuCaps.hasSSE, gCpuCaps.hasSSE2);
>  #ifdef RUNTIME_CPUDETECT
> -  mp_msg(MSGT_CPLAYER,MSGL_INFO, MSGTR_CompiledWithRuntimeDetection);
> +  mp_msg(MSGT_CPLAYER,MSGL_V, MSGTR_CompiledWithRuntimeDetection);
> [..]

I'm against changing all of these messages except the annoying 'runtime' 
one.

> -	mp_msg(MSGT_CFGPARSER,MSGL_INFO,"\n");
> + 	mp_msg(MSGT_CFGPARSER,MSGL_V,"\n");

This one is good, remove this...

> -    mp_msg(MSGT_DECVIDEO,MSGL_INFO,MSGTR_VoConfigRequest,w,h,vo_format_name(preferred_outfmt));
> +    mp_msg(MSGT_DECVIDEO,MSGL_V,MSGTR_VoConfigRequest,w,h,vo_format_name(preferred_outfmt));

Don't remove this, it's the only message that shows the resolution of the 
video before scaling. Also it let's you know if somehow the 'vc' demanded a 
new config() halfway through the movie. (like a broken video with changing 
resolution...)

> -    mp_msg(MSGT_CPLAYER,MSGL_INFO,"VDec: using %s as output csp (no %d)\n",vo_format_name(out_fmt),j);
> +    mp_msg(MSGT_CPLAYER,MSGL_V,"VDec: using %s as output csp (no %d)\n",vo_format_name(out_fmt),j);

I think you can remove this, what it says can be drawn as conclusion from 
other messages...

- ods15