[MPlayer-dev-eng] Re: [PATCH] http1 to ingore DEMUXER_TYPE_ASF unconditionally

Alban Bedel albeu at free.fr
Fri Oct 14 17:55:29 CEST 2005


On Fri, 14 Oct 2005 23:25:06 +0800
Zuxy <zuxy.meng at gmail.com> wrote:

> 2005/10/14, Alban Bedel <albeu at free.fr>:
> >
> > Anyway such global variable is not acceptable. This belong in stream->priv
> > or the like.
> 
> So Alban, what do you suggest?
> 
> 1. Cast void* stream->priv to a bool without malloc or free.
> 2. malloc a bool and store the pointer in stream->priv, and we have to
> write a close_s function, too.

The exact implemtation doesn't really matter as long as this is
stored with the rest of the stream data and not in a global.
imho 2) is better in the long run, but 1) would do it too atm.

	Albeu




More information about the MPlayer-dev-eng mailing list