[MPlayer-dev-eng] Re: [PATCH] demuxers: move resync_audio_stream call to demuxer.c

Alban Bedel albeu at free.fr
Fri Oct 14 23:12:53 CEST 2005


On Fri, 14 Oct 2005 21:38:46 +0200
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> demuxer.c is still missing the prototype for the resync_audio_stream.
> Would you find a special prototype or #include "libmpcodecs/dec_audio.h"
> preferable?

libmpdemux is supposed to work "standalone", so unless dec_audio.h is
alredy included somewhere else a prototype is probably better.

imho it's probably better to only calls resync_audio_stream() if something
did happend (or at least was supposed to) as in: 


-if (demuxer->desc->seek)
+if (demuxer->desc->seek) {
     demuxer->desc->seek(demuxer,rel_seek_secs,flags);
 
+    if (sh_audio) resync_audio_stream(sh_audio);
+}

and

     if (res == DEMUXER_CTRL_NOTIMPL)
       index = demuxer->audio->id;
+    else if (demuxer->audio) resync_audio_stream(demuxer->audio);
     return index;

	Albeu




More information about the MPlayer-dev-eng mailing list