[MPlayer-dev-eng] [PATCH] mencoder to load win32 codecs properly

[Sascha Sommer]

On Friday 14 October 2005 13:21, Guillaume POIRIER wrote:
> Hi,
>
> On 10/14/05, Sascha Sommer <saschasommer at freenet.de> wrote:
> > On Friday 14 October 2005 08:35, Zuxy wrote:
> > > 2005/10/13, Sascha Sommer <saschasommer at freenet.de>:
> > > > On Thursday 13 October 2005 14:51, Reimar Döffinger wrote:
>
> [..]
>
> > > And to Sascha, I'm not quite familiar for the security implication of
> > > string operations. What I do is just to move the code from mplayer.c
> > > to get_path.c, replace the hardcoded filename and add some message
> > > outputs, which may need further modification as you suggested. So may
> > > I say the patch is at least as secure as the original code? And since
> > > WIN32_PATH is a compile-time constant I don't think it'll be utilized
> > > to cause a buffer overflow at runtime by a hacker. Anyway, if we added
> > > the option mentioned above we should take further consideration.
> >
> > The current patch should be save when the compile time constants are
> > sane.
> >
> > > So, I'd better resend the patch or you would edit it yourself? Thanks.
> >
> > I think I'll commit the patch as is (without some of the mp_msgs). If it
> > is wanted the other issue can still be changed later.
>
> I was about to propose the same as the patch doesn't make functional
> change to the existing code, and since it's best to split bigger
> changes to separate commits...
>

Patch applied and sorry for the delay...

Regards

Sascha