[MPlayer-dev-eng] [PATCH] fix dvd miscompilation

Nico Sabbi nsabbi at tiscali.it
Sun Oct 23 21:03:12 CEST 2005


Hi,
this patch fixes compilation when you specify --disable-mpdvdkit 
--disable-dvdread.

I added to configure two variables to export  to config.mak and config.h:
DVDREAD (currently unused, but may be necessary later)
and HAVE_DVD ("yes" if any of mkdvdkit1/2 or dvdread is "yes").

I had to #ifdef HAVE_DVD almost all the code in stream_dvd.c (a 
technique that I
abhor) , because there are some global variables in the file that are 
used by demux_mkv.
When Moritz fixes that bad behavior we can conditionally compile 
stream_dvd.c
(adding in Makefile an ifeq($(HAVE_DVD),yes).

If no one object I will commit this patch tomorrow.

    Nico
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dvd.diff
Type: text/x-patch
Size: 3147 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20051023/c041d290/attachment.bin>


More information about the MPlayer-dev-eng mailing list