[MPlayer-dev-eng] [PATCH] configure to detect prescott and nocona
Diego Biurrun
diego at biurrun.de
Tue Oct 25 15:27:33 CEST 2005
On Mon, Oct 24, 2005 at 11:09:37AM -0700, Corey Hickey wrote:
> Diego Biurrun wrote:
> >>I moved a part of the x86 section wherein configure sets pname, pvendor,
> >>etc.. This is now its own section, and is run 'if (x86 || x86_64)'
> >
> > What would be the advantage of that?
>
> It's actually essential for allowing the amd64 optimization to work,
> which uses a 'case "$pvendor" in' to decide what optimizations to try.
>
> -----------------------------------------------------------------------
> case "$pvendor" in
> AuthenticAMD)
> proc=k8;;
> GenuineIntel)
> # 64-bit prescotts exist, but as far as GCC is concerned they have the
> # same capabilities as a nocona.
> proc=nocona;;
> *)
> proc=error;;
> esac
> -----------------------------------------------------------------------
>
> I moved the whole block surrounding pvendor because those lines all go
> together, and in the future the x86_64 checks will probably depend on
> other variables set there.
>
> > Patch applied with some modifications and without moving the section.
>
> Could you please do so now? Applying my patch without that part breaks
> all x86_64 optimization. I've attached a new patch.
Thanks, applied.
Diego
More information about the MPlayer-dev-eng
mailing list