[MPlayer-dev-eng] [PATCH] faster MPEG demuxing

Rich Felker dalias at aerifal.cx
Sat Sep 3 12:41:30 CEST 2005


On Sat, Sep 03, 2005 at 10:59:26AM +0200, Reimar Döffinger wrote:
> Hi,
> On Wed, Aug 31, 2005 at 02:10:01AM +0200, Reimar D?ffinger wrote:
> > well, actually it is mostly a fix for my horribly gxf demuxer. But the
> > parse_es.c seem to be a bit faster like this, too.
> > What do you think about it? Especially the __builtin_expect macros can
> > make quite a difference in some cases, that's why this patch would
> > define them in config.h (I admit, probably not the best place,
> > suggestions as always welcome...)
> > Please comment and test (i.e. benchmark).
> 
> Applied.

Can you please fix this to use better names? #define'ing a lowercase
english word in a project-global header is highly inappropriate, imo.
I guess it's not so bad since the macro only expands if immediately
followed by parentheses, but namespace-polluting macro definitions are
one of my pet peeves.

Rich




More information about the MPlayer-dev-eng mailing list