[MPlayer-dev-eng] [PATCH] libvo: GGI driver update

Dominik 'Rathann' Mierzejewski dominik at rangers.eu.org
Mon Sep 5 21:03:26 CEST 2005


On Monday, 05 September 2005 at 17:15, Christoph Egger wrote:
> 
> Hello!
> 
> I have a patch which updates the ggi driver.
> It only touches libvo/vo_ggi.c
> 
> I suggest the following commit log:
> ----------------------------------------------------
> - switch coding style to K&R
> - improved performance on truecolor modes
> - fixed all known bugs, i.e. palette mode works right again
> ----------------------------------------------------
> 
> 
> Please review and apply. Tnx in advance.

This is totally unacceptable. Patches mixing cosmetic and
functional changes, especially on such scale, will be rejected
without review.

Make two patches. One that fixes the bugs and another that makes
the cosmetic changes.

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"




More information about the MPlayer-dev-eng mailing list