[MPlayer-dev-eng] [PATCH] libvo: GGI driver update

[Ivo]

On Tuesday 06 September 2005 15:24, Christoph Egger wrote:
> I can live that statement.
> What is the mplayer's _general_ coding style?

AFAIK there's no such thing.

> I'm told be the maintainer for the ggi driver (However, I'm not aware
> of any account information). The code in CVS (up to rev 1.37) is a mix
> of tabs and spaces. I believe this state comes over time from different
> people, one likes tabs, the other likes spaces...
> As a maintainer I should have the right to
> say 'Stop. Please don't make it worse...'

Yes. The maintainer of a certain piece of code decides on the layout of that 
code, so if you really want tabs in there, I guess that's allright, but I 
agree with Reimar. I prefer spaces instead of tabs. That will look the same 
everywhere, despite the tabwidth settings. When I looked at your patch the 
first time, I thought there were numerous lines of 90+ characters, untill I 
found out you used tabs all over the place.

--Ivo