[MPlayer-dev-eng] NUT cleanup

[Rich Felker]

On Tue, Sep 06, 2005 at 08:21:21PM +0300, Oded Shimon wrote:
> > > > >  checksum
> > > > >  	adler32 checksum
> > > > > +	checksum is calculated for the area pointed to by forward_ptr not
> > > > > +	including the checksum itself (from first byte after the
> > > > > +	forward_ptr until last byte before the checksum).
> > > > 
> > > > somehow i think forward_ptr should be included in the checksum, dunno 
> > > 
> > > It makes more "sense", but it's harder to implement. Also it really won't 
> > > protect you any more from corruption..
> > 
> > ok, if rich agrees iam fine with this though iam slightly in favor of having
> > the forward_ptr in the checksumed area
> 
> /me pokes Rich...
> 
> The harder implementation part is that it means i need to re-implement 
> get_v for the demuxer where it reads forward_ptr, every byte read 
> has to be pushed into the memory buffer - because all of 
> forward_ptr needs to be stored in ram as well as the data...

Oded, you MUST keep everything in a memory buffer anyway. Otherwise
it's impossible to return with EAGAIN when there's not enough data
available yet..

Rich