[MPlayer-dev-eng] [PATCH] libvo: GGI driver update

[Reimar Döffinger]

Hi,
On Thu, Sep 08, 2005 at 08:10:07PM +0200, Christoph Egger wrote:
> > How about addressing Reimar's review now?  He had some questions and
> > suggested some improvements.
> 
> I did. I changed the if in get_image() as he suggested.
> 
> And to answer his question about ggi_conf.async - this variable
> was only used for debugging and thus removed. The actual asynchronous
> mode is set via ggiSetFlags()

That leaves the questions why you moved some things (draw_slice
function, async setting, ), and I consider this cosmetics:
-    if ((char *) arg) {
+    if (arg != NULL) {
       int i = 0;
       ggi_conf.driver = strdup(arg);
-        while (ggi_conf.driver[i]) {
+        while (ggi_conf.driver[i] != '\0') {

Greetings,
Reimar Döffinger