[MPlayer-dev-eng] libvo: GGI driver update

[Christoph Egger]

> > > I believe Reimar already made a comment about it, but why did you
> > > move draw_slice up? It's hard to see what exactly changed. Right
> > > now it's between flip_page and query_format, so please keep it
> > > there for clarity.
> > 
> > The reason is logical order. With this move, draw_frame(), draw_osd()
> > and draw_slice() are grouped together.
> > 
> > With this move you have some rough "sections" in vo_ggi.c:
> > 
> > 1. Datatypes
> > 2. Configuration
> > 3. rendering (get_image, draw_*)
> > 4. (un)initialization
> > 5. event handling
> > 
> > If you count this move as cosmetic and don't like it because of this,
> > I'll undo it.
> 
> The move is cosmetic.  If you wish to move the function, please send a
> separate patch.

New patch without the move.

-- 
Greetings,

Christoph

GMX DSL = Maximale Leistung zum minimalen Preis!
2000 MB nur 2,99, Flatrate ab 4,99 Euro/Monat: http://www.gmx.net/de/go/dsl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_ggi.c.functional_diff
Type: application/octet-stream
Size: 14036 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050911/95654292/attachment.obj>