[MPlayer-dev-eng] [PATCH] for some issues

[Meihui Fan]

Reimar Döffinger wrote:
> Hi,
> On Thu, Sep 15, 2005 at 01:16:19PM +0800, Meihui Fan wrote:
> 
>>	  switch(priv->frmt) {
>>	  case WAV:
>>-	    pos -= (pos % (sh_audio->channels * sh_audio->samplesize) );
>>+	    pos += (sh_audio->wf->nBlockAlign >> 1);
>>+	    pos -= ((pos - demuxer->movi_start) % sh_audio->wf->nBlockAlign);
> 
> 
> Not acceptable by this, because in the past -ao pcm produced files with
> blockalign set to 0. Also I find it overly complicated, wouldn't
> if (sh_audio->wf && sh_audio->wf->nBlockAlign)
> pos += pos % sh_audio->wf->nBlockAlign;
> be good enough?
It's fine, but it seems the sh_audio->wf is always true according the 
demux_audio_open.
> 
> 
>>-	#define MAXFRAMESIZE 1280
>>+	#define MAXFRAMESIZE  1792
> 
> 
> Do you have samples? And what is the effect when this value is too
> small?
The MPEG audio framesize in the attatched sample file is 1728, so it is 
rejected by MPlayer with the default mp3lib audio codec. But it works by 
specifying -afm ffmpeg.
> 
> 
>>	$(PRG_CFG): version.h codec-cfg.c codec-cfg.h
>>-		$(HOST_CC) $(HOST_CFLAGS) -I. -g codec-cfg.c mp_msg.c -o $(PRG_CFG) -DCODECS2HTML $(EXTRA_LIB) $(EXTRA_INC) $(I18NLIBS)
>>+		$(HOST_CC) $(HOST_CFLAGS) -I. -g codec-cfg.c mp_msg.c -o $(PRG_CFG) -DCODECS2HTML
> 
> 
> I agree with removing I18NLIBS, but I am unsure about the others...
> 
> Greetings,
> Reimar Döffinger
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 

-- 
Best Regards,
范美辉 (Meihui Fan)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: stream.dump
Type: application/octet-stream
Size: 68578 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050915/ee90c3f3/attachment.obj>