[MPlayer-dev-eng] [PATCH] big vf_osd update

Diego Biurrun diego at biurrun.de
Thu Sep 15 15:39:52 CEST 2005


On Wed, Sep 14, 2005 at 03:28:35PM -0400, Jason Tackaberry wrote:
> 
> Incorporating the suggestions received by Reimar and Michael, as well as
> the documentation fixes offered by Wanderer, attached is an updated
> vf_osd patch with many changes from the last.  Here is an overview:
> 
>       * Removed custom colorspace conversion code and rewrote to use
>         Swscaler.
>       * Improve slave command argument parsing to properly deal with
>         malformed commands.
>       * Fixed a bug where colorspace conversion was being done
>         needlessly for global alpha changes.
>       * control() returns CONTROL_OK for VFCTRL_PAUSE_UPDATE; mplayer.c
>         checks this return value in the pause loop and will sleep longer
>         if it is not handled.  (Pause loop now sleeps the same amount of
>         time as before if no osd filter is loaded.)  Tested gmplayer to
>         ensure pause loop changes created no ill effects.

These look like things that you might wish to submit as separate patches.
It would make reviewing them easier and speed up the integration of
vf_overlay.

Diego




More information about the MPlayer-dev-eng mailing list