[MPlayer-dev-eng] [PATCH] big vf_osd update

[Jason Tackaberry]

On Thu, 2005-09-15 at 17:31 +0200, Reimar Döffinger wrote:
> I don't know what Diego exactly wanted... I for me have to say thank
> you for your effort, but those patches aren't worth anything to me since
> I hadn't finished reviewing the other part.

I wasn't sure if they'd be very useful either, but I was asked, so
whatever helps getting vf_overlay reviewed. :)

> Though there is one thing I'd like to ask: The pause update VFCTRL I
> think can be applied seperately, maybe you can cut that out so it can be
> reviewed seperately.
> The reason for this is that
> 1) I think this is the only part that can break something existing
> 2) Is really small and thus more probable to be reviewed.

Seems sensible.

The mplayer.c patch modifies the pause loop, but it also modifies the
sleep timers so that the overlay update rate can work independently of
the movie's frame rate.  (This allows for a responsive overlay for low
framerate videos.)  Given that, perhaps VFCTRL_PAUSE_UPDATE is a
misnomer.  Perhaps VFCTRL_SLEEP_UPDATE instead?  Or perhaps have two
VFCTRLs?  What's your sense on this?

Cheers,
Jason.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: This is a digitally signed message part
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050915/690d05b0/attachment.pgp>