[MPlayer-dev-eng] [PATCH] VFCTRL_PAUSE_UPDATE

Jason Tackaberry tack at sault.org
Thu Sep 15 20:30:06 CEST 2005


On Thu, 2005-09-15 at 18:56 +0200, Reimar Döffinger wrote:
> Actually I'd like to suggest the attached patch instead.
[...]
> +static int periodic_update(vf_instance_t *vf, vo_functions_t *vo,
> +                           float time_avail) {
> +  int res;
> +  if (!vf) return 0;
> +  if (time_avail < 0.01) return 1; 

Actually this last line is a bit arbitrary.  In fact, 1000 microseconds
is a lot of time depending on what needs to be done.  And what needs to
be done will depend on the filter.  Why not remove that constraint and
let the filter decide if it should update or not?  Since the filter is
given time_avail and it knows what it needs to do, it will be able to
make a more intelligent choice.

(And empirically commenting this line out this seems to work better for
me.)

Cheers,
Jason.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: This is a digitally signed message part
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050915/78f3c733/attachment.pgp>


More information about the MPlayer-dev-eng mailing list