[MPlayer-dev-eng] [PATCH] -identify DVD titles

Rich Felker dalias at aerifal.cx
Mon Sep 19 22:50:51 CEST 2005


On Mon, Sep 19, 2005 at 10:29:00PM +0200, Guillaume POIRIER wrote:
> I'm also not too sure that 
> +  static int framerates[4] = {0, 2500, 0, 2997};
> +  int framerate = framerates[(dt->frame_u & 0xc0) >> 6];
> +  int msec = (((dt->hour & 0xf0) >> 3) * 5 + (dt->hour & 0x0f)) * 3600000;
> 
> is well supported by ol' compilers such as GCC-2.95. Could you check that?

The code is perfectly fine syntactically, even in traditional C, but
plain wrong in what it does. The numbers are 25 and 30000/1001, not 25
and 29.97!!

Rich




More information about the MPlayer-dev-eng mailing list