[MPlayer-dev-eng] [PATCH] -identify DVD titles

kiriuja mplayer-patches at en-directo.net
Tue Sep 20 01:41:40 CEST 2005


On 9/19/05, Guillaume POIRIER wrote:
> How about using snprintf to copy just the 15 first chars maybe? I'm
> just suggesting...

No real difference, except I'd have to build a va_list myself. Plus
snprintf may not be portable.

On 9/19/05, Ivo wrote:
>> How about:
>> 
>> "ID_DVD_DISC_ID=%016LX%016LX\n",
>> bswap_64(*(uint64_t *)discid), bswap_64(*(uint64_t *)&discid[8]) );
>> 
>> Or is that considered equally ugly? :)
>
> BTW better use be2me_64 so its endian safe.

More hackish, for sure. Does not improve readability at all. :)

Could we please leave that part like it is now?

--
kiriuja




More information about the MPlayer-dev-eng mailing list