[MPlayer-dev-eng] [PATCH] Remove font attributes from subtitles

Salvatore Falco sfalco at studenti.ing.uniroma1.it
Wed Sep 21 14:57:25 CEST 2005


> I'm not competent to evaluate the patch's functionality, at least not
> without a lot more effort than I want to invest right now (although
> proper advanced subtitle feature support is something I'd very much like
> to see - it's the number-one most wanted missing feature I see mentioned
> in the fora I frequent, mostly a few newsgroups), but a couple of points
> which need to be addressed regardless:

> printf() should not be used, please either remove this (if it was
> intended purely for debugging purposes and won't be useful later on) or
> change it to mp_msg().
> 
> Also, is there any particular reason why the line is not indented at
> all?

All the printf are for debugging pourposes, and the missing indetation makes
them much more evident when I want to remove them.
As I told, this is a patch I provide to those interested in expanding the
functionality, not a patch to enter into MPlayer CVS.

Best regards,
    Salvatore Falco
    




More information about the MPlayer-dev-eng mailing list