[MPlayer-dev-eng] [PATCH] verbosity reduction

[The Wanderer]

Robert Henney wrote:

> On Mon, Sep 19, 2005 at 08:59:57PM +0200, Roberto Togni wrote:
> 
>> On Mon, 19 Sep 2005 10:05:53 +0200
> 
> [..]
> 
>> Please don't move messages to level higher than -v.
>> -v -v is unuseable (you pratically need to redirect it to a file)
>> because it prints too much stuff during playback.
>> 
>> If you really want to reduce -v verbosity, a new intermediate level
>> have to be introduced.
> 
> what I would love to see, but would be much too complex beyond
> consideration is a way to increase and decrease verbosity for
> particular parts of mplayer.
> 
> say, -verbose mux=+1,filt=+2,vo=-1,gen=-1 [ etc.. ] which would
> increase the verbosity 1 level on the muxer code, up by 2 levels
> within filters, and down by 1 on video out and general sections.

Why would that be prohibitively complex? On the surface it seems fairly
simple; create a "verbosity" variable for each such category, set it to
be initially equal to MSGL_STATUS (which is the default verbosity), sum
it with the value passed for that category on the command line, and then
change every mp_msg call to be of the form "mp_msg(MSGT_FOO, MSGL_FOO +
verbosity, ...) (where "verbosity" is the appropriate variable for the
context in which the call is made). The only tricky thing I see right
off (on the design level) seems to be making sure the verbosity variable
is going to be available at the time of the call, without having them
all be global.

I don't understand the command-line parsing code, and don't know where
the rest of the code would need to go, or I might be able to do it
myself. Unless, of course, there's some fundamental thing I've missed
which would increase the problem's complexity beyond what is readily
tractable.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.