[MPlayer-dev-eng] [PATCH] Switch audio streams in AVI files

[Rich Felker]

On Fri, Sep 30, 2005 at 04:39:37PM +0200, Guillaume POIRIER wrote:
> Hi,
> 
> On 9/30/05, Jochen Leopold <jochen.leopold at fh-hagenberg.at> wrote:
> > I extended the source code to enable audio switching during the playback
> > of AVI files.
> >
> >
> > There are two files affected:
> >  - libmpdemux/demux_avi.c
> >  - mplayer.c
> >
> > I had to add a initialisation routine in mplayer.c for the switched
> > audio streams.
> > It was the only possibility to allow switching between different types
> > of audio streams.
> 
> Did you look at the way it was done for AVI and Mkv? It does seem to
> me like your solution is overkill.

Nothing could be further from the truth.
First of all, stream switching is NOT SUPPORTED for avi.
Second, the stream switching in mpeg and mkv that we have right now is
broken crap. It only works if the codec and codec parameters are
identical.

This patch is the correct approach that should have been done all
along! However, it may not be the correct implementation.

> > +/* LAva END */
> 
> spam, spam, spam, spam! :-)
> 
> Please submit a patch with less spam. Commenting your code is good,
> but it has to make sense when it gets re-read. That sure does not make
> much sense to me.

Agree totally.

Rich