[MPlayer-dev-eng] [PATCH] SSA/ASS subtitles support

[Alexander Strange]

On Mar 31, 2006, at 5:09 PM, Evgeniy Stepanov wrote:

> Hi
>
> Here is an attempt to add ASS rendering capability to mplayer. It is
> designed as a filter and supports a large part of ASS so-called
> specification. Reads both external subtitles and the ones embedded in
> matroska.

Some things I notice on OS X:

* This uses strndup(), which doesn't exist outside glibc.
* You left a hardcoded freetype path in libmpcodecs/Makefile.
* Is it really necessary to memcpy every frame in the filter? I'm  
working on removing memcpy from vo_macosx, and I don't want more put  
in the filter chain.
* Using fontconfig on OS X will be really bad for people who don't  
have X11 installed, since it will have to rescan the system font  
directories every time it starts. There's not really a good solution  
here, though, unless someone wants to write a fontconfig-ATSUI shim.

Also, the kerning looks weird on some lines and the letters are all  
very thin compared to Windows' VSFilter or any other player's current  
subtitle handling, but I haven't investigated this very hard.