[MPlayer-dev-eng] [PATCH] SSA/ASS subtitles support

[Evgeniy Stepanov]

On Saturday 01 April 2006 17:11, Attila Kinali wrote:
> I just had a short look at it and a few things came to my mind:
> 1) would it be possible to make this more general to handle
> other subtitles too?  Then we could get rid of the current
> subtitle mess.

Surely it's possible. All the subtitle sources (subreader + demuxers) have to 
be modified to write subtitle events to new structures instead of subdata. 
Its format is expressive enough to support anything (vobsub excepted).

> 2) The filter can just handle YV12, which is bad, it should
> at least be able to handle the most comon YUV formats.

Agreed. I'll do it in some time.

> 3) i'd put the subtitle code into its own directory than
> poluting libmpcodecs which already has too many files.

Already in the latest patch.

> 4) Had you have a look at vf_expand.c ? it does partially
> the same as you do.

It does not have to draw multiple overlapping transparent images. I've given 
it much thought and looks like it is impossible in YV12. So i'm converting 
parts of the image containing subtitles to 4:4:4 and back.

> 5) would you be willing to take over the maintenance
> of the subtitle code?

I would not be able to give it much time, plus reading the current subtitle 
code gives me headaches ;) I can look into general subtitle support in the 
filter though.