[MPlayer-dev-eng] [PATCH] win32 gui

[Guillaume POIRIER]

Hi,

On 4/2/06, Erik Lunchpail <erik_27can at yahoo.com> wrote:
>
> > Updated to current CVS. The debug console will now show the cpu
> > extensions mplayer was compiled with, and to be consistent, i've
> > changed the "Skin" directory to "skins".
>
> New patch. Added a new preferences setting to enable/disable using the
> sub window as WinID. Should allow people to still use directx if they
> prefer not to have the sub window using WinID (although it's still
> recommended, especially if using dvd menu's because it tracks dvdnav
> mouse events.)

I've had a look at the code, and the very good point is that your
patches are very clean, which makes reviewing easy.

Now, I can't test, and I'm not one of MPlayer's coders, so I can't
comment on many other things.

All I can say is that I'd very much like to see that patch merged _if
you're willing to stick around to maintain it_.

One of MPlayer's greatest weak point is that current gui is
unmaintained, and isn't that great, so it would really be a shame to
commit some more code if I was to follow the same tragic path...

Guillaume

--
I am disillusioned enough to know that no man's opinion on any subject
is worth a damn unless backed up with enough genuine information to
make him really know what he's talking about.

-- H. P. Lovecraft (about the flamewars on FFmpeg and MPlayer-dev mailing lists)
http://www.brainyquote.com/quotes/quotes/h/hplovecr278144.html