: Re: [MPlayer-dev-eng] [PATCH] fix compilation on intel mac

[Nicolas Plourde]

On 9-Apr-06, at 1:20 AM, Rich Felker wrote:

> On Sat, Apr 08, 2006 at 11:59:59PM +0100, Martin Simmons wrote:
>>>>>>> On Thu, 6 Apr 2006 20:37:32 -0400, Nicolas Plourde  
>>>>>>> <nicolas.plourde at gmail.com> said:
>>>
>>> --- mangle.h	30 Mar 2003 20:11:05 -0000	1.6
>>> +++ mangle.h	4 Apr 2006 11:28:04 -0000
>>> @@ -9,7 +9,7 @@
>>>
>>>  /* Feel free to add more to the list, eg. a.out IMO */
>>>  #if defined(__CYGWIN__) || defined(__MINGW32__) || defined 
>>> (__OS2__) || \
>>> -   (defined(__OpenBSD__) && !defined(__ELF__))
>>> +   (defined(__OpenBSD__) || defined(__APPLE__) && !defined 
>>> (__ELF__))
>>
>> This looks wrong to me, since it will break not-ELF detection on  
>> OpenBSD.
>>
>> Did you mean this?
>>
>>  #if defined(__CYGWIN__) || defined(__MINGW32__) || defined 
>> (__OS2__) || \
>> -   (defined(__OpenBSD__) && !defined(__ELF__))
>> +   (defined(__OpenBSD__) && !defined(__ELF__)) || defined(__APPLE__)
>
> I think he meant to remove all this CRAP and write a proper test for
> symbol mangling in configure... :)
>
> Rich
>

I really meant the first version and i dont see how its breaking  
OpenBSD. And no i will not write a proper test in configure but feel  
free to do it if you have the time.

Now anyone have any real concern about this patch? If not i will  
submit it.

====
Nicolas Plourde <nicolas.plourde at gmail.com>