[MPlayer-dev-eng] [PATCH] Fix too small HEADER_SEARCH_SIZE in demux_nsv.c

[Guillaume POIRIER]

Hi,

On 4/8/06, Soeren Sonnenburg <mplayer-ml at nn7.de> wrote:
> Hi list,
>
> Trying to play the demoscene.tv nsv at http://213.186.36.129:8000
> I realized that HEADER_SEARCH_SIZE is too small in quite a number of
> cases, causing the stream to not be played.
>
> So I set HEADER_SEARCH_SIZE to some huge value and counted at which
> position 'NSV' is found in the stream. Then I repeatedly connected to
> this server ( >250 times). Here are the results:
>
> minimum 'NSV' offset: 681
> maximum 'NSV' offset: 950367 (!)
> average 'NSV' offset: 99089
> standard deviation: 125789
>
> As currently HEADER_SEARCH_SIZE is 65000 you - on average - won't be
> able to play that stream.
>
> The attached one-liner-patch simply sets HEADER_SEARCH_SIZE to 2097152,
> which should be sufficient for all current nsv streams...

It does fix the problem, and RC confirmed it.

I plan to apply this, as it's a trivial 'fix', unless someone disagrees.

Guillaume
--
I am disillusioned enough to know that no man's opinion on any subject
is worth a damn unless backed up with enough genuine information to
make him really know what he's talking about.

-- H. P. Lovecraft (about the flamewars on FFmpeg and MPlayer-dev mailing lists)
http://www.brainyquote.com/quotes/quotes/h/hplovecr278144.html