[MPlayer-dev-eng] [PATCH] fix compilation on intel mac

Rich Felker dalias at aerifal.cx
Sat Apr 15 06:52:14 CEST 2006


On Sat, Apr 15, 2006 at 01:17:52AM +0200, Diego Biurrun wrote:
> On Wed, Apr 05, 2006 at 07:00:13PM -0400, Rich Felker wrote:
> > On Wed, Apr 05, 2006 at 11:51:28PM +0200, Diego Biurrun wrote:
> > > On Wed, Apr 05, 2006 at 01:50:20PM +0200, Aurelien Jacobs wrote:
> > > > 
> > > > Maybe it would be time to remove all those tabs in some parts of
> > > > MPlayer ? (at least in files whose maintainers agree ?)
> > > 
> > > I'm all for it.  Are you volunteering to do the work?
> > 
> > I'm against it in the files I maintain, which use all tabs and no
> > spaces, quite intentionally.
> 
> Look closer, you have a mix of tabs and spaces at least in pullup.c.

There is one line that includes both tabs and spaces and it's very
intentional. The tabs indent to the same level as the previous line,
and then the spaces provide the additional alignment to where I want
the text to align to in the previous line. Note that this will look
correct with _any_ tab width setting. That's entirely different from
what's meant by "mixing tabs and spaces".

Rich




More information about the MPlayer-dev-eng mailing list