[MPlayer-dev-eng] [PATCH] switch audio delay keys

[Ivo]

On Saturday 15 April 2006 17:06, Ivan Kalvachev wrote:
> 2006/4/15, Diego Biurrun <diego at biurrun.de>:
> > On Tue, Apr 04, 2006 at 09:05:31AM +0200, Diego Biurrun wrote:
> > > After Uoti Urpala's mail I've stumbled over the fact that the keys
> > > that set audio delay are backwards from what is documented...
> > >
> > > man page:
> > >
> > >   + and -
> > >     Adjust audio delay by +/- 0.1 seconds.
> > >
> > > code:
> > >
> > >   { { '-', 0 }, "audio_delay 0.100" },
> > >   { { '+', 0 }, "audio_delay -0.100" },
> > >
> > > So I suggest the attached patch to bring this in line with the
> > > documentation.  Increasing the delay with '+' and decreasing it with
> > > '-' is the only sane way...
> >
> > Applied.
>
> Did you ever make the effort to read the discusion before going ahead
> and commit that?

Not speaking for Diego here, but I don't think it really matters which way 
around the keys are bound. You will probably press the wrong one 50% of the 
time anyhow ;) Maybe more.

I did always see the + key as skipping forward in the audiostream though, 
i.e. increasing the negativeness of the delay :)

--Ivo