[MPlayer-dev-eng] [PATCH] Faad update, try2

[Diego Biurrun]

On Fri, Apr 14, 2006 at 06:39:22PM +0200, Diego Biurrun wrote:
> On Wed, Apr 12, 2006 at 01:20:46AM +0200, Roberto Togni wrote:
> > 
> > Works with all my samples.
> > Works with sky.fm streams.
> > Should work with fixed point (please test), but afaik not all features
> > are supported in fixed-point mode (same as current faad in MPlayer cvs)
> > 
> > Some fixes are coded by exg.
> > 
> > Please test.
> 
> Bandit.mp4 still crashes in fixed mode, but this also happens with the
> current version.  Other than that it works fine for me.
> 
> I made some benchmarks on my PowerBook (1500MHz G4, Debian unstable)
> with samples available from
> 
> http://www.mplayerhq.hu/MPlayer/samples/A-codecs/AAC/
> 
> ct_faac.mp4 and  ct_nero-heaac.mp4 are audio-only files, for them I used
> the command
> 
> mplayer -benchmark -ao pcm:file=/dev/null:fast:nowaveheader
> 
> For zx.eva.renewal.01.divx511.mkv I used
> 
> mplayer -vc null -vo null -benchmark -ao pcm:file=/dev/null:fast:nowaveheader
> 
> I took the best of 5 runs.  For float mode I took 20 runs after getting
> wildly varying results on the zx.eva.renewal.01.divx511.mkv sample.  The
> new version seems to be slightly faster even though I don't trust the
> numbers too much.
> 
> Roberto, maybe double-check with some benchmarks on x86 and finally
> commit this, we have been waiting for an updated FAAD version for ages.

Here are the numbers from my x86 box (K6-III 500, Debian stable).  One
sample plays about 1% slower in float mode with the updated libfaad, the
other values have improved.

Roberto, I would say commit ASAP :-)

Diego


current:

ct_faac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   1.395s Sys:   0.005s =    1.400s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 99.6622% Sys:  0.3378% = 100.0000%

ct_nero-heaac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   3.785s Sys:   0.006s =    3.791s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 99.8416% Sys:  0.1584% = 100.0000%

zx.eva.renewal.01.divx511.mkv:
BENCHMARKs: VC:   0.004s VO:   0.000s A:  65.774s Sys:   0.191s =   65.969s
BENCHMARK%: VC:  0.0053% VO:  0.0000% A: 99.7044% Sys:  0.2903% = 100.0000%


updated:

ct_faac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   1.409s Sys:   0.005s =    1.414s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 99.6572% Sys:  0.3428% = 100.0000%

ct_nero-heaac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   3.759s Sys:   0.005s =    3.764s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 99.8564% Sys:  0.1436% = 100.0000%

zx.eva.renewal.01.divx511.mkv:
BENCHMARKs: VC:   0.004s VO:   0.000s A:  65.784s Sys:   0.193s =   65.981s
BENCHMARK%: VC:  0.0055% VO:  0.0000% A: 99.7014% Sys:  0.2931% = 100.0000%


fixed mode:

current:

ct_faac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   1.160s Sys:   0.005s =    1.165s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 99.5707% Sys:  0.4293% = 100.0000%

ct_nero-heaac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.620s Sys:   0.003s =    0.623s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 99.5317% Sys:  0.4683% = 100.0000%

zx.eva.renewal.01.divx511.mkv:
BENCHMARKs: VC:   0.003s VO:   0.000s A:  11.353s Sys:   0.123s =   11.479s
BENCHMARK%: VC:  0.0265% VO:  0.0000% A: 98.8994% Sys:  1.0741% = 100.0000%


updated:

ct_faac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   1.136s Sys:   0.005s =    1.141s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 99.6032% Sys:  0.3968% = 100.0000%

ct_nero-heaac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.616s Sys:   0.003s =    0.618s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 99.5517% Sys:  0.4483% = 100.0000%

zx.eva.renewal.01.divx511.mkv:
BENCHMARKs: VC:   0.003s VO:   0.000s A:  11.162s Sys:   0.121s =   11.286s
BENCHMARK%: VC:  0.0276% VO:  0.0000% A: 98.8961% Sys:  1.0763% = 100.0000%