[MPlayer-dev-eng] [PATCH] disable filters that depend on dsputil.h

Ivan Kalvachev ikalvachev at gmail.com
Wed Apr 19 14:22:28 CEST 2006


2006/4/17, Nico Sabbi <nicola_sabbi at fastwebnet.it>:
> Nico Sabbi wrote:
>
> > Diego Biurrun wrote:
> >
> >> On Mon, Mar 20, 2006 at 01:35:38PM +0100, Diego Biurrun wrote:
> >>
> >>
> >>> On Thu, Mar 16, 2006 at 11:06:35PM +0100, Nico Sabbi wrote:
> >>>
> >>>
> >>>> as for Ivan's request on IIRC I committed only configure,
> >>>> libmpcodecs/Makefile and libmpcodecs/vf.c,
> >>>> because the filter files can be modified in a different way.
> >>>>
> >>>
> >>> And how?  IMO this is just code obfuscation.  If it cannot and does not
> >>> work with shared lavc, the code should not imply it does.
> >>>
> >>
> >>
> >> Nico?
> >>
> >> Diego
> >>
> >>
> >
> >
> > sorry for the delay, I missed your previous mail.
> >
> > Ivan's intention (IIRC) was to change the  #include directive so as if
> > users
> > use external libavcodec and copy dsputil.h  in a global include directive
> > those filters can be still used
> >
>
> After Diego's request on irc I committed the changes to the filter
> files, too.

Never do that again.

I did flame diego on irc. Do you really want to flame you too?

Always put warning and arguments on the mailling list. Diego is not
project leader, nor some kind of dictator to overthrow other
developers decisions.




More information about the MPlayer-dev-eng mailing list