[MPlayer-dev-eng] [PATCH] disable filters that depend on dsputil.h

[Ivan Kalvachev]

2006/4/19, Diego Biurrun <diego at biurrun.de>:
> On Wed, Apr 19, 2006 at 03:22:28PM +0300, Ivan Kalvachev wrote:
> > 2006/4/17, Nico Sabbi <nicola_sabbi at fastwebnet.it>:
> > > Nico Sabbi wrote:
[...]
> > > After Diego's request on irc I committed the changes to the filter
> > > files, too.
> >
> > Never do that again.
> >
> > I did flame diego on irc. Do you really want to flame you too?
> >
> > Always put warning and arguments on the mailling list. Diego is not
> > project leader, nor some kind of dictator to overthrow other
> > developers decisions.
>
> Nor are you if I may remind you.
>
> You have things backwards.  It's not Nico and I that have to justify our
> actions, it's you.

I don't have the right to write angry mails, when somebody does
something sneaky behind my back? You may have not noticed, but I don't
like the WAY this was committed, not the changes that were committed.
Actually Nico was quite reasonable and even explained quite well my
position in this thread.

> Shared lavc support was implemented by myself and Nico.  While doing this
> Nico put some #ifdef lines in lavc-dependent filters.  Michael spoke up
> against (mis)using nonpublic header files, so the support for shared
> lavc was removed from these filters again.

Michael was against installing internal headers as part of ffmpeg
installation. AFAIK he never argued against using them to build *spp
filter with external ffmpeg. (of course using dynamically linked
ffmpeg is quite risky in such case, but static linking must be OK).


> If you want to keep some leftover #ifdef lines in a filter, come up with
> a good reason to keep them and a working implementation *first*.  #ifdef
> is to be avoided, especially if it just obfuscates the code without
> working.

I'm going to do one step more. I'm starting new thread with patch that
removes about 28 lines total while bringing back the "left overs".  It
uses a trick very similar to the one freetype uses.

Let's talk about code.