[MPlayer-dev-eng] [PATCH] fixed point faad, gnu assembler etc.

[Roberto Togni]

On Sat, 22 Apr 2006 20:36:30 +0200
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> On Sat, Apr 22, 2006 at 08:28:29PM +0200, Reimar D?ffinger wrote:
> > This one seems better, and does produce quite sane-looking code (tested
> > with gcc 4.1 for 64 bit, gcc 2.95 for 32).
> > Heavy benchmarking (and any other kind of testing) would still be welcome though.
> 
> bah..

Quick test results:
works with mphq samples + sky.fm streams, but it does not decode SBR
(eg. SBR files where you get 44100Hz with float mode you get 22050Hz
with fixed) and PS seems disabled too (sky.fm streams sound "mono"
even if they have 2 channles).
SBR can be enabled by commenting out line 127 in common.h, and
everything seems fine for SBR files (probably also with PS files,
judging only by ear).

Quick "benchmark": on my P4 fixed mode have cpu 6.1%, while float uses
2.6%. i have not tested fixed mode without your patch.


So imo: it can be applied but not set as default if we keep SBR
disabled; if wqe enable SBR some more extensive benchmark is needed to
decide if we want to change current default.

Ciao,
 Roberto