[MPlayer-dev-eng] [PATCH] MSGT_IDENTIFY (was: option to skip slow -identify output)

[Oded Shimon]

On Sat, Apr 22, 2006 at 09:46:03AM -0400, kiriuja wrote:
> On Saturday 22 April 2006 09:16 Oded Shimon wrote:
> > On Thu, Apr 20, 2006 at 06:13:21PM -0400, kiriuja wrote:
> > > +    mp_msg_levels[MSGT_IDENTIFY] = -1; // no -identify output by default
> > 
> > I dislike this hack.
> > 
> > IMO you should make all identify MSGL_V, and the very bad ones, MSGL_DBG1 
> > (or 2 or whatever it was).
> 
> Currently there is no identify output unless you give -identify, regardless
> of the global msglevel. There is no reason to change that. So -1 is the
> only correct value for the default MSGT_IDENTIFY level.

Right, didn't realize that, ok.

> > Also, the man page should note that identify output is available by 
> > -msgl identify=..
> 
> The patch already includes a mention of that in mplayer.1.

Sorry, I meant it should mention that MORE output is available by -msgl 
identify=5 . It doesn't. Other than that, patch OK.

- ods15