[MPlayer-dev-eng] Re: [PATCH] Various improvement in TOOLS/cpuinfo.c

Diego Biurrun diego at biurrun.de
Tue Apr 25 10:39:13 CEST 2006


On Tue, Apr 25, 2006 at 04:22:15PM +0800, Zuxy Meng wrote:
> 2006/4/25, Zuxy Meng <zuxy.meng at gmail.com>:
> 
> Absolutely sorry, bug found in previous patch. This one fixes it.

Please resend an updated version of your patch, stacking patches is more
work and error-prone.

> --- main/TOOLS/cpuinfo.c	2006-04-25 16:19:42.000000000 +0800
> +++ main.new/TOOLS/cpuinfo.c	2006-04-25 16:17:23.000000000 +0800
> @@ -228,7 +228,7 @@
>        family += (regs.eax >> 20) & 0xff;
>        model += ((regs.eax >> 16) & 0xf) << 4;
>      }
> -    
> +

Rejected: cosmetics

Please resend an updated patch without the cosmetics.

Diego




More information about the MPlayer-dev-eng mailing list