[MPlayer-dev-eng] Re: [PATCH] Various improvement in TOOLS/cpuinfo.c

[Dominik 'Rathann' Mierzejewski]

On Tuesday, 25 April 2006 at 10:44, Zuxy Meng wrote:
[...]
> @@ -147,16 +158,16 @@
>        { 15, "cmov",  "Conditional Move/Compare Instruction" },
>        { 16, "pat",   "Page Attribute Table" },
>        { 17, "pse36", "Page Size Extension 36-bit" },
> -      { 18, "psn",   "Processor Serial Number" },
> +      { 18, "pn",   "Processor Serial Number" },
                       ^^^
Nit: misalignment. ;)

>        { 19, "cflsh", "CFLUSH instruction" },
> -      { 21, "ds",    "Debug Store" },
> +      { 21, "dts",    "Debug Store" },

Same here.

>        { 22, "acpi",  "Thermal Monitor and Clock Ctrl" },
>        { 23, "mmx",   "MMX Technology" },
>        { 24, "fxsr",  "FXSAVE/FXRSTOR" },
>        { 25, "sse",   "SSE Extensions" },
>        { 26, "sse2",  "SSE2 Extensions" },
>        { 27, "ss",    "Self Snoop" },
> -      { 28, "htt",   "Multi-threading" },
> +      { 28, "ht",   "Multi-threading" },

And here. Don't be afraid to add/remove a single space if the
change warrants it. :)

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan