[MPlayer-dev-eng] [PATCH] Add support for GNOME screensaver

[Diego Biurrun]

On Wed, Apr 26, 2006 at 08:43:38PM +0200, Piotr Kaczuba wrote:
> Attached is the third revision of the patch. I've considered Diego
> Biurrun's remarks regarding the configure script and made a cvs diff
> (thanks to Corey Hickey for explaining how to do it properly).

> --- Makefile	25 Apr 2006 02:01:21 -0000	1.367
> +++ Makefile	26 Apr 2006 18:11:41 -0000
> @@ -307,7 +308,7 @@
>  	$(MAKE) -C libmpeg2
>  
>  libvo/libvo.a:
> -	$(MAKE) -C libvo
> +	$(MAKE) -C libvo all

Why?

> --- configure	26 Apr 2006 01:59:05 -0000	1.1179
> +++ configure	26 Apr 2006 18:11:41 -0000
> @@ -6815,6 +6819,22 @@
>  fi
>  echores "$_gethostbyname2"
>  
> +echocheck "D-BUS GLib interface"
> +if test "$_dbus_glib" != no && pkg-config --exists dbus-glib-1; then

The check should only run when _dbus_glib is set to auto.  The value yes
is reserved to force the setting.

> @@ -8116,6 +8138,14 @@
>  OPTIONAL_OBJS = $_voobj
>  EOF
>  
> +if test "$_x11" = yes -a "$_dbus_glib" = yes; then
> +  cat >> libvo/config.mak << EOF
> +
> +gnome_screensaver.o: gnome_screensaver.c
> +	\$(CC) -c \$(CFLAGS) \$(DBUS_GLIB_INC) -o \$@ $<
> +EOF

I don't like this.  These rules belong in the Makefile, not somewhere
else.

Diego