[MPlayer-dev-eng] Re: [PATCH] Allow aspect change in TS and DVB

[Ivan Kalvachev]

2006/4/25, Carl Eugen Hoyos <cehoyos at ag.or.at>:
> Ivan Kalvachev <ikalvachev <at> gmail.com> writes:
>
> >
> > 2006/4/25, Nico Sabbi <nicola_sabbi <at> fastwebnet.it>:
> > > Nico Sabbi wrote:
> > >
>
> [...]
>
> > >
> > > btw2, this patch should also work for ffmpeg12. Does it?
>
> No, because for my samples (DVB and TS), ffmpeg12 never changes the output
> windows resolution or position. It simply ignores aspect change.

Use the CVS not the antient release.
It was especially requested for DVB aspect changes.


> > The right place to fix this bug is in vd_mpeg12.c or libmpeg2.
>
> Thanks for the suggestion. New patch below.

Rejected.
You should not fill video.c with (lib)mpeg12 specific stuff.
Try again.

>
> >
> > ffmpeg12 already detects and re-initializes the video system on aspect change.
>
> For me, ffmpeg12 never re-initialized the video system;-(
> And I thougth it's a feature of ffmpeg12: Never change users changes!
> Libmpeg2, on the other hand, re-initializes the video on aspect change, but
> always uses the former aspect. That's what the patch fixes (now without demuxer
> check).

Hum. The ffmpeg12 decoder does reinitliaze itself and call pix_format
(or whatever functions there was for quering supported pixel format).
It seems that vf_ffmpeg doesn't notice the aspect change and doesn't
care why all buffers are freed and allocated again ;)