[MPlayer-dev-eng] Last call for pre8

[Uoti Urpala]

On Thu, 2006-04-27 at 23:01 +0200, Roberto Togni wrote:
> * new release critical bugs:
> - b-frames + lavc in mencoder are reported to be broken

This is caused by lavc encoder rejecting bad timestamps from mencoder. I
believe the old behaviour can be restored for now by always setting the
timestamps in ve_lavc.c to MP_NOPTS_VALUE, but I haven't taken more than
a superficial look.

> - vf_ass: commit or wait?

It likely has more bugs to be fixed later, but it is already useful with
several files. It might be committable in a state where it at least
doesn't break anything if it is not explicitly used. It would need some
fixes and more review before that though, so if the release is supposed
to be in one or two days then probably not. The issues I know that
probably would need to be fixed:
- The security check for font save paths (with font name coming from the
played file) only checks that the name portion doesn't contain '/',
should at least check for '\' under Windows (and maybe more, would need
to verify which characters are safe under which OSes).
- The fonts are always saved when playing an mkv file containing them,
if it's committed as "at least doesn't break anything if not used" this
should probably be turned off by default (there's already an option to
turn font saving off, so changing the default would be enough)
- Maybe version checks for font libraries used so configure doesn't
detect an old version and then fail at compile time (the problem
recently reported by Jan Knutar).