[MPlayer-dev-eng] [PATCH] mention libdvdnav in 'configure --help' and switch autodetection on

[The Wanderer]

Nico Sabbi wrote:

> The Wanderer wrote:
> 
>> Apparently, even though configure recognizes the '--enable-dvdnav',
>>  '--with-dvdnavdir' and '--with-dvdnav-config' options, they are
>> not listed in 'configure --help' - and, possibly as a result,
>> dvdnav support still defaults to "no" with autodetection run if it
>> is set to "yes". The attached patch corrects both points. If there
>> was some reason why dvdnav was disabled by default, it should still
>> be listed as such in the help output; in any case, it appears to
>> compile just fine for me, though I'm not presently in a position to
>> test the resulting binary.
>
>> echocheck "DVD support (libdvdnav)"
>> -if test "$_dvdnav" = yes ; then
>> +if test "$_dvdnav" = auto ; then
> 
> +if test "$_dvdnav" != no ; then

Unfortunately, this means that the detection will be run even if
'--enable-dvdnav' is specified, which disagrees with our preferred
syntax. Admittedly the detection in question is mostly a matter of
making sure that the (specified or guessed) dvdnav-config and dvdnavdir
are correct, but if the --enable option is specified, AIUI this should
not be done...

> if you set _dvdnav to auto you should also make sure that there's
> actually some dvdnav-config in the system, or compilation may fail;
> the rest is fine for me

I agree that this could be a problem - I was tired enough last night not
to think of it - but I'm not 100% certain I know how to do that
(although it's percolating...). As an interim hack, would failing out
( == setting _dvdnav to no) if _dvdnav_config is not set and
'dvdnav-config' cannot be executed be an acceptable solution?

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.