[MPlayer-dev-eng] [PATCH] Track names in matroska
Paul Lebedev
paul.lebedev at gmail.com
Sat Aug 5 19:22:05 CEST 2006
On Saturday, August 05, 2006 18:44, Evgeniy Stepanov wrote:
> On Thursday 15 June 2006 21:32, Paul Lebedev wrote:
> > Hi.
> >
> > This patch displays track names in matroska files which helps
> > distinguish multiple tracks of the same type and language.
> >
> > And a couple of questions about mkv demuxer:
> > 1. While there is -alang and -slang, there is no support
> for choosing
> > video track by language, is anything like -vlang possible?
> > 2. demux_mkv_read_trackentry initializes track->language
> with "eng",
> > shouldn't it be "unk"?
> > (strdup'ed "eng" is also leaked when the real language
> is read, but
> > it's not the only "small" leak I've seen looking through
> > the code, so I suppose it's ok... )
>
> What about this patch ?
>
> I'd prefer to keep old behaviour in case of an untitled
> track, and not print "(untitled)". Other than that, no
> objections. A useful feature.
>
I agree, this seems to be a better way.
More information about the MPlayer-dev-eng
mailing list