[MPlayer-dev-eng] [PATCH] Bug with SWS_FAST_BILINEAR and runtime CPU detection in libswscale

[Uoti Urpala]

On Sat, 2006-08-12 at 13:27 +0200, Michael Niedermayer wrote:
> On Fri, Aug 11, 2006 at 08:40:06PM -0400, Jason Tackaberry wrote:
> > is dereferenced in the asm code).  However, the code that allocates the
> > memory for this in swscale.c doesn't get compiled because in swscale.c
> > HAVE_MMX2 got undefined.
> > 
> > The attached patch fixes this problem by redefining HAVE_* when they
> > have a corresponding COMPILE_* define
> 
> rejected, AFAIK the problem was introduced with the r19339 change, the 
> solution is to reverse that

I think this could be fixed by using #ifdef COMPILE_MMX2 instead of
#ifdef HAVE_MMX2 without reverting the whole r19339.

However when I checked that I noticed there are other uses of HAVE_MMX2
after the #undef lines for swscale_template, added in revision 3153. Did
I miss something obvious or has this been broken for almost 5 years (not
using all the optimized routines)?