[MPlayer-dev-eng] [PATCH] Support asf aspect ratio

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Dec 3 15:08:56 CET 2006


Hello,
On Sun, Dec 03, 2006 at 09:58:28PM +0800, Zuxy Meng wrote:
>  ////////////////////////
> +// ASF Metadata Record
> +////////////////////////
> +typedef struct __attribute__((packed)) {

I know the existing code does that, but please avoid that
__attribute__((packed)), direct reading into memory etc. crap in new
code, this is a horrible and non-portable coding style.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list