[MPlayer-dev-eng] [PATCH] ASS subtitle speedup (take 2)

[Evgeniy Stepanov]

On Saturday 02 December 2006 23:22, Reimar Döffinger wrote:
> Hello,
>
> On Sat, Dec 02, 2006 at 10:59:31PM +0300, Evgeniy Stepanov wrote:
> > On Saturday 02 December 2006 22:33, Reimar Döffinger wrote:
> > > > > Though I wonder if/how the imgs->imgs == NULL && imgs->changed == 1
> > > > > case should be handled (your code probably would crash?).
> > > >
> > > > Why should it ? imgs->imgs == NULL is nothing special, just a list of
> > > > zero elements.
> > >
> > > Because the original patch did
> > > goto skip_upload;
> > > without checking img!=NULL and the code at skip_upload did assume it to
> > > be != NULL IIRC.
> >
> > I still don't see how it depends on that, but ok, extra check won't hurt.
> > A new version fixing everything that was discussed.
>
> No obvious problems (also had a quick look at the other code).

In fact there is one: subtitles going from "disabled" to "enabled" (either 
with 'j' or with track switching) does not count as a change, and display is 
not updated. My solution is inelegant but seems to work. Any ideas ?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ass-speed4.patch
Type: text/x-diff
Size: 8583 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061204/ed672e02/attachment.patch>