[MPlayer-dev-eng] [PATCH] Properly support cddb disabling

[Reimar Doeffinger]

Hello,
On Mon, Dec 04, 2006 at 09:45:13AM +0100, Diego Biurrun wrote:
> On Sun, Dec 03, 2006 at 10:39:56PM +0100, Reimar Döffinger wrote:
> > is attached patch okay?
> > 
> > --- configure	(revision 21478)
> > +++ configure	(working copy)
> > @@ -5300,6 +5328,15 @@
> >      _noinputmodules="cdda $_noinputmodules"
> >  fi
> >  
> > +if test "$_cddb" = yes ; then
> > +    _def_cddb='#define HAVE_CDDB'
> > +    _inputmodules="cddb $_inputmodules"
> > +else
> > +    _cddb=no
> 
> This line shouldn't be necessary, _cddb should be 'yes' or 'no' at this
> point.

Since the autodetection currently only consists of this line:
test $_cddb = auto && test $_network = yes && not darwin && _cddb=yes
no, it will usually still be auto at that point.
Of course the line above could be changed, but that seems needlessly
complicated.

Greetings,
Reimar Doeffinger